Rescue exceptions raised when calling to_s while sanitizing #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean that every to_s will display [SPOOF] if it throws? Any reason we cant to_s earlier the ip in the middleware earlier and rescue [SPOOF] there? |
When calling to_s will raise, rescue and insert a placeholder.
If a ActionDispatch::RemoteIp instance cannot be memoized, it throws an IpSpoofAttackError from to_s. In this case, replace the IP with a placeholder. Ref: https://github.com/rails/rails/blob/34fe2a4fc778d18b7fe6bdf3629c1481bee789b9/actionpack/lib/action_dispatch/middleware/remote_ip.rb#L134
|
We can. |
kattrali
force-pushed
the
kattrali/avoid-raising-in-client_ip
branch
from
758a030
to
8e4389d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that calling to_s will raise, like in
ActionDispatch::RemoteIp::IpSpoofAttackError, rescue and insert a placeholder.Relevant example